Skip to content

OCPBUGS-55288: Added note about bonded interface and node IP address … #92534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

OCPBUGS-55288: Added note about bonded interface and node IP address … #92534

merged 1 commit into from
May 2, 2025

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 23, 2025 •
edited
Loading

Version(s): 4.12+

Issue:
OCPBUGS-55228

Link to docs preview:

  • SME has approved this change (B.Nemec).
  • QE has approved this change (Ross.B).

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key OCPBUGS-55288 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

…issues

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2025
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key OCPBUGS-55288 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):

Issue:
OCPBUGS-55228

Link to docs preview:

  • SME has approved this chanage.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 23, 2025 •
edited
Loading

🤖 Wed Apr 30 09:30:14 - Prow CI generated the docs preview:

https://92534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html

palonsoro
palonsoro reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@palonsoro palonsoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I made a review with what the comment should look like. However, I see it is focused in baremetal IPI edge clusters, while we would need to document this for all kinds of both baremetal IPI and UPI clusters (and text might slightly change between scenarios).

So not sure if you could please move/clone the text to wherever it applies and we can then do further review.

Thanks.

@dfitzmau dfitzmau force-pushed the OCPBUGS-55228 branch 2 times, most recently from 31f6c85 to d0ba02a Compare April 24, 2025 10:22
cybertron
cybertron reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

At some point I think we want more explicit documentation about the two-step process that can be used in day one configuration, but for now this is better than nothing.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-55288, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:
OCPBUGS-55228

Link to docs preview:

  • SME has approved this chanage.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-55288, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.12+

Issue:
OCPBUGS-55228

Link to docs preview:

  • SME has approved this change (B.Nemec).
  • QE has approved this change (Ross.B).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau merged commit dc2bc0f into openshift:main May 2, 2025
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-55288: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55288 has been moved to the MODIFIED state.

In response to this:

Version(s): 4.12+

Issue:
OCPBUGS-55228

Link to docs preview:

  • SME has approved this change (B.Nemec).
  • QE has approved this change (Ross.B).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2025

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92911

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92912

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92913

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Closed
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92914

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2025
Closed
@openshift-cherrypick-robot
Copy link

@dfitzmau: #92534 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-55288: Added note about bonded interface and node IP address issues
.git/rebase-apply/patch:121: trailing whitespace.
Before installing {product-title}, you must configure the network properly to ensure that the edge subnets containing the remote nodes can reach the subnet containing the control plane nodes and receive traffic from the control plane too. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc
M	modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
M	modules/ipi-install-establishing-communication-between-subnets.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-establishing-communication-between-subnets.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-establishing-communication-between-subnets.adoc
Auto-merging modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
Auto-merging installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-55288: Added note about bonded interface and node IP address issues

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #92534 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-55288: Added note about bonded interface and node IP address issues
.git/rebase-apply/patch:121: trailing whitespace.
Before installing {product-title}, you must configure the network properly to ensure that the edge subnets containing the remote nodes can reach the subnet containing the control plane nodes and receive traffic from the control plane too. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc
M	modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
M	modules/ipi-install-establishing-communication-between-subnets.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-establishing-communication-between-subnets.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-establishing-communication-between-subnets.adoc
Auto-merging modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
Auto-merging installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-55288: Added note about bonded interface and node IP address issues

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #92534 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-55288: Added note about bonded interface and node IP address issues
.git/rebase-apply/patch:121: trailing whitespace.
Before installing {product-title}, you must configure the network properly to ensure that the edge subnets containing the remote nodes can reach the subnet containing the control plane nodes and receive traffic from the control plane too. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc
M	modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
M	modules/ipi-install-establishing-communication-between-subnets.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-establishing-communication-between-subnets.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-establishing-communication-between-subnets.adoc
Auto-merging modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
Auto-merging installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-55288: Added note about bonded interface and node IP address issues

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #92534 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-55288: Added note about bonded interface and node IP address issues
.git/rebase-apply/patch:121: trailing whitespace.
Before installing {product-title}, you must configure the network properly to ensure that the edge subnets containing the remote nodes can reach the subnet containing the control plane nodes and receive traffic from the control plane too. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A	installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc
M	modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
M	modules/ipi-install-establishing-communication-between-subnets.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-establishing-communication-between-subnets.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-establishing-communication-between-subnets.adoc
Auto-merging modules/ipi-install-configuring-host-network-interfaces-in-the-install-config.yaml-file.adoc
CONFLICT (modify/delete): installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc deleted in HEAD and modified in OCPBUGS-55288: Added note about bonded interface and node IP address issues. Version OCPBUGS-55288: Added note about bonded interface and node IP address issues of installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-55288: Added note about bonded interface and node IP address issues

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 2, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@palonsoro palonsoro palonsoro left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

Assignees

@cybertron cybertron

@rbbratta rbbratta

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @michaelryanpeter @rbbratta @openshift-cherrypick-robot @cybertron @palonsoro